-
Notifications
You must be signed in to change notification settings - Fork 54
Admin API filter to search users by username #5015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploying matrix-authentication-service-docs with
|
Latest commit: |
a7e56b3
|
Status: | ✅ Deploy successful! |
Preview URL: | https://5a0b290c.matrix-authentication-service-docs.pages.dev |
Branch Preview URL: | https://quenting-admin-api-user-sear.matrix-authentication-service-docs.pages.dev |
-- This enables the pg_trgm extension, which is used for search filters | ||
-- Starting Posgres 16, this extension is marked as "trusted", meaning it can be | ||
-- installed by non-superusers | ||
CREATE EXTENSION IF NOT EXISTS pg_trgm; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only tricky thing is that before PG 16 you have to be superuser to execute that. Which is probably fine in most Docker environments for example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm yikes. Feels like something we should at least call out somewhere, v15 still has another 2 years on it and I'm not sure people will know how to run this manually as a superuser.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two things to do:
- add documentation to the database page and upgrade notes for this migration, for Pg <= 15;
- check that if the superuser on Pg 15 already created the extension, whether a non-superuser is then able to complete the migration as a no-op?
I will add things in the docs. We don't have upgrade notes, so it will have to be manual in the release notes somehow. I did check for
|
@reivilibre I've added things in the documentation in a3ecdc9 and put what should be added to the release notes in the PR body, wdyt? |
release notes mostly OK, would just say that maybe it needs a more obvious 'If you are using Postgres 15 or earlier and MAS doesn't run as a Postgres superuser, run Might just be me but I feel it's easy to miss the fact I might need to do something, in the current text. |
a3ecdc9
to
a7e56b3
Compare
After double-checking, turns out trusted extensions were a thing introduced in PG 13, which is the version we ask for anyway. So I reverted the docs change |
No description provided.